Re: [PATCH v6 4/5] media: platform: mediatek: isp_30: add mediatek ISP3.0 camsv

[CK Hu (胡俊光)]

Hi, Julien:

On Mon, 2024-07-29 at 16:48 +0200, Julien Stephan wrote:
>  	 
> External email : Please do not click links or open attachments until you have verified the sender or the content.
>  From: Phi-bang Nguyen <pnguyen@xxxxxxxxxxxx>
> 
> This driver provides a path to bypass the SoC ISP so that image data
> coming from the SENINF can go directly into memory without any image
> processing. This allows the use of an external ISP.
> 
> Signed-off-by: Phi-bang Nguyen <pnguyen@xxxxxxxxxxxx>
> Signed-off-by: Florian Sylvestre <fsylvestre@xxxxxxxxxxxx>
> [Paul Elder fix irq locking]
> Signed-off-by: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx>
> Co-developed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Co-developed-by: Julien Stephan <jstephan@xxxxxxxxxxxx>
> Signed-off-by: Julien Stephan <jstephan@xxxxxxxxxxxx>
> ---

[snip]

> +static void mtk_cam_dev_load_default_fmt(struct mtk_cam_dev *cam)
> +{
> +struct mtk_cam_video_device *vdev = &cam->vdev;
> +struct v4l2_pix_format_mplane *fmt = &vdev->format;
> +
> +fmt->num_planes = 1;
> +fmt->pixelformat = vdev->desc->fmts[0];
> +fmt->width = vdev->desc->def_width;

fmt->width = IMG_MAX_WIDTH;

So you could drop def_width.

> +fmt->height = vdev->desc->def_height;

fmt->height = IMG_MAX_HEIGHT;

So you could drop def_height.

Regards,
CK

> +
> +fmt->colorspace = V4L2_COLORSPACE_SRGB;
> +fmt->field = V4L2_FIELD_NONE;
> +fmt->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;
> +fmt->quantization = V4L2_QUANTIZATION_DEFAULT;
> +fmt->xfer_func = V4L2_XFER_FUNC_DEFAULT;
> +
> +vdev->fmtinfo = mtk_cam_format_info_by_fourcc(fmt->pixelformat);
> +
> +calc_bpl_size_pix_mp(vdev->fmtinfo, fmt);
> +}
> +