Re: [PATCH] selinux: Fix potential counting error in avc_add_xperms_decision()

[Leizhen (ThunderTown)]

On 2024/8/7 17:16, Leizhen (ThunderTown) wrote:
> 
> 
> On 2024/8/7 0:30, Markus Elfring wrote:
>>> The count increases only when a node is successfully added to
>>> the linked list.
>>
>> 1. Please improve such a change description with an imperative wording.
>>    https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc2#n94
> Ok, I'll try to improve it.
I see this patch has been merged into selinux/stable-6.11. So I decided not to
change it, and I re-examined it, and it seems that there is no problem you
mentioned.

> 
>>
>> 2. How do you think about to omit the word “potential” from the summary phrase?
> I added "potential" because it's unlikely that the memory request will fail. Maybe "possible" would
> be better.
> 
> 
>>
>>
>> Regards,
>> Markus
>> .
>>
> 

-- 
Regards,
  Zhen Lei