Re: [PATCH] selinux: Fix potential counting error in avc_add_xperms_decision()
From: Leizhen (ThunderTown)
Date: Wed Aug 07 2024 - 05:16:54 EST
On 2024/8/7 0:30, Markus Elfring wrote:
>> The count increases only when a node is successfully added to
>> the linked list.
>
> 1. Please improve such a change description with an imperative wording.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc2#n94
Ok, I'll try to improve it.
>
> 2. How do you think about to omit the word “potential” from the summary phrase?
I added "potential" because it's unlikely that the memory request will fail. Maybe "possible" would
be better.
>
>
> Regards,
> Markus
> .
>
--
Regards,
Zhen Lei