Re: linux-next: build warnings after merge of the rcu tree
From: Z qiang
Date: Fri Aug 09 2024 - 02:18:35 EST
>
> Hi all,
>
> After merging the rcu tree, today's linux-next build (htmldocs) produced
> these warnings:
>
> kernel/rcu/tasks.h:54: warning: Function parameter or struct member 'index' not described in 'rcu_tasks_percpu'
> kernel/rcu/tasks.h:127: warning: Function parameter or struct member 'rtpcp_array' not described in 'rcu_tasks'
>
Hello, Stephen Rothwell
Please apply it:
diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
index 4e913e5ca737..52ee77516260 100644
--- a/kernel/rcu/tasks.h
+++ b/kernel/rcu/tasks.h
@@ -34,6 +34,7 @@ typedef void (*postgp_func_t)(struct rcu_tasks *rtp);
* @rtp_blkd_tasks: List of tasks blocked as readers.
* @rtp_exit_list: List of tasks in the latter portion of do_exit().
* @cpu: CPU number corresponding to this entry.
+ * @index: index number corresponding to this entry in rtpcp_array.
* @rtpp: Pointer to the rcu_tasks structure.
*/
struct rcu_tasks_percpu {
@@ -77,6 +78,7 @@ struct rcu_tasks_percpu {
* @call_func: This flavor's call_rcu()-equivalent function.
* @wait_state: Task state for synchronous grace-period waits
(default TASK_UNINTERRUPTIBLE).
* @rtpcpu: This flavor's rcu_tasks_percpu structure.
+ * @rtpcp_array: Pointer array of used to store rtpcpu pointer.
* @percpu_enqueue_shift: Shift down CPU ID this much when enqueuing callbacks.
* @percpu_enqueue_lim: Number of per-CPU callback queues in use for enqueuing.
* @percpu_dequeue_lim: Number of per-CPU callback queues in use for dequeuing.
Thanks
Zqiang
> Introduced by commit
>
> a79e0e72ffa6 ("rcu-tasks: Fix access non-existent percpu rtpcp variable in rcu_tasks_need_gpcb()")
>
> --
> Cheers,
> Stephen Rothwell