Re: [PATCH] staging: drivers: scsi: lpfc: Fix warning: Using plain integer as NULL pointer in lpfc_init.c

From: Justin Tee
Date: Mon Aug 12 2024 - 12:24:36 EST


Hi Dipendra,

Perhaps the branch being referred to is out of date?

This has already been addressed in the following commit.

commit 5860d9fb5622ecd79913ac981403c612f6c8a2d8
Author: Colin Ian King <colin.i.king@xxxxxxxxx>
Date: Sat Sep 25 23:41:13 2021 +0100

scsi: lpfc: Return NULL rather than a plain 0 integer

Function lpfc_sli4_perform_vport_cvl() returns a pointer to struct
lpfc_nodelist so returning a plain 0 integer isn't good practice. Fix this
by returning a NULL instead.

Link: https://lore.kernel.org/r/20210925224113.183040-1-colin.king@xxxxxxxxxxxxx
Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
Signed-off-by: Martin K. Petersen martin.petersen@xxxxxxxxxx


And, the routine called lpfc_enable_node doesn’t exist anymore.

Regards,
Justin Tee