Re: [PATCH] staging: drivers: scsi: lpfc: Fix warning: Using plain integer as NULL pointer in lpfc_init.c

From: Dipendra Khadka
Date: Thu Aug 15 2024 - 15:03:13 EST


Hi Justin,

On Mon, 12 Aug 2024 at 22:09, Justin Tee <justintee8345@xxxxxxxxx> wrote:
>
> Hi Dipendra,
>
> Perhaps the branch being referred to is out of date?
>

Sorry, you are right. It is due to the branch mismatching.

> This has already been addressed in the following commit.
>
> commit 5860d9fb5622ecd79913ac981403c612f6c8a2d8
> Author: Colin Ian King <colin.i.king@xxxxxxxxx>
> Date: Sat Sep 25 23:41:13 2021 +0100
>
> scsi: lpfc: Return NULL rather than a plain 0 integer
>
> Function lpfc_sli4_perform_vport_cvl() returns a pointer to struct
> lpfc_nodelist so returning a plain 0 integer isn't good practice. Fix this
> by returning a NULL instead.
>
> Link: https://lore.kernel.org/r/20210925224113.183040-1-colin.king@xxxxxxxxxxxxx
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> Signed-off-by: Martin K. Petersen martin.petersen@xxxxxxxxxx
>
>
> And, the routine called lpfc_enable_node doesn’t exist anymore.
>
> Regards,
> Justin Tee

Best Regard,
Dipendra Khadka