[PATCH 1/3] crypto: spacc - Fix uninitialized variable in spacc_aead_process()
From: Dan Carpenter
Date: Thu Aug 15 2024 - 07:20:26 EST
Smatch complains that:
drivers/crypto/dwc-spacc/spacc_aead.c:1031 spacc_aead_process()
error: uninitialized symbol 'ptaadsize'.
This could happen if, for example, tctx->mode was CRYPTO_MODE_NULL and
req->cryptlen was less than icvremove.
Fixes: 06af76b46c78 ("crypto: spacc - Add SPAcc aead support")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---
drivers/crypto/dwc-spacc/spacc_aead.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/crypto/dwc-spacc/spacc_aead.c b/drivers/crypto/dwc-spacc/spacc_aead.c
index 3468ff605957..50ef9053fc4d 100755
--- a/drivers/crypto/dwc-spacc/spacc_aead.c
+++ b/drivers/crypto/dwc-spacc/spacc_aead.c
@@ -823,7 +823,7 @@ static int spacc_aead_process(struct aead_request *req, u64 seq, int encrypt)
u32 dstoff;
int icvremove;
int ivaadsize;
- int ptaadsize;
+ int ptaadsize = 0;
int iv_to_context;
int spacc_proc_len;
u32 spacc_icv_offset = 0;
@@ -974,8 +974,6 @@ static int spacc_aead_process(struct aead_request *req, u64 seq, int encrypt)
tctx->mode == CRYPTO_MODE_NULL) {
if (req->cryptlen >= icvremove)
ptaadsize = req->cryptlen - icvremove;
- } else {
- ptaadsize = 0;
}
/* Calculate and set the below, important parameters
--
2.43.0