[PATCH 2/3] crypto: spacc - Fix NULL vs IS_ERR() check in spacc_aead_fallback()

From: Dan Carpenter
Date: Thu Aug 15 2024 - 07:20:41 EST


The crypto_alloc_aead() function doesn't return NULL pointers, it returns
error pointers. Fix the error checking.

Fixes: 06af76b46c78 ("crypto: spacc - Add SPAcc aead support")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---
drivers/crypto/dwc-spacc/spacc_aead.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/dwc-spacc/spacc_aead.c b/drivers/crypto/dwc-spacc/spacc_aead.c
index 50ef9053fc4d..da9df329f9d4 100755
--- a/drivers/crypto/dwc-spacc/spacc_aead.c
+++ b/drivers/crypto/dwc-spacc/spacc_aead.c
@@ -784,9 +784,9 @@ static int spacc_aead_fallback(struct aead_request *req,
ctx->fb.aead = crypto_alloc_aead(aead_name, 0,
CRYPTO_ALG_NEED_FALLBACK |
CRYPTO_ALG_ASYNC);
- if (!ctx->fb.aead) {
+ if (IS_ERR(ctx->fb.aead)) {
pr_err("Spacc aead fallback tfm is NULL!\n");
- return -EINVAL;
+ return PTR_ERR(ctx->fb.aead);
}

subreq = aead_request_alloc(ctx->fb.aead, GFP_KERNEL);
--
2.43.0