RE: [PATCH] clk: starfive: Use pm_runtime_resume_and_get to fix pm_runtime_get_sync() usage

[Xingyu Wu]

On 15/08/2024 20:19, Yuntao Liu wrote:
> 
> We need to call pm_runtime_put_noidle() when pm_runtime_get_sync() fails,
> so use pm_runtime_resume_and_get() instead. this function will handle this.
> 
> Fixes: dae5448a327ed ("clk: starfive: Add StarFive JH7110 Video-Output clock
> driver")
> Signed-off-by: Yuntao Liu <liuyuntao12@xxxxxxxxxx>
> ---
>  drivers/clk/starfive/clk-starfive-jh7110-vout.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/starfive/clk-starfive-jh7110-vout.c
> b/drivers/clk/starfive/clk-starfive-jh7110-vout.c
> index 53f7af234cc2..aabd0484ac23 100644
> --- a/drivers/clk/starfive/clk-starfive-jh7110-vout.c
> +++ b/drivers/clk/starfive/clk-starfive-jh7110-vout.c
> @@ -145,7 +145,7 @@ static int jh7110_voutcrg_probe(struct platform_device
> *pdev)
> 
>  	/* enable power domain and clocks */
>  	pm_runtime_enable(priv->dev);
> -	ret = pm_runtime_get_sync(priv->dev);
> +	ret = pm_runtime_resume_and_get(priv->dev);
>  	if (ret < 0)
>  		return dev_err_probe(priv->dev, ret, "failed to turn on
> power\n");
> 

It looks good. Thanks for your patch.

Reviewed-by: Xingyu Wu <xingyu.wu@xxxxxxxxxxxxxxxx>

Best regards,
Xingyu Wu