Re: [PATCH] clk: renesas: rzv2h-cpg: Fix undefined reference to r9a09g057_cpg_info

From: Geert Uytterhoeven
Date: Mon Aug 19 2024 - 11:11:23 EST


Hi Prabhakar,

On Mon, Aug 5, 2024 at 11:58 AM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Address randconfig build issue where the linker reports an undefined
> reference to `r9a09g057_cpg_info`. The error occurs when
> CONFIG_CLK_R9A09G057 is not defined, leading to the inclusion of the
> device match entry without the corresponding data. By adding a
> preprocessor condition to the device match table, the entry for
> r9a09g057 is included only when CONFIG_CLK_R9A09G057 is defined, thus
> resolving the linker error.
>
> Error message:
> /usr/bin/ld: warning: .tmp_vmlinux1 has a LOAD segment with RWX permissions
> >> /usr/bin/ld: drivers/clk/renesas/rzv2h-cpg.o:(.rodata+0xc0): undefined reference to `r9a09g057_cpg_info'
> clang-14: error: linker command failed with exit code 1 (use -v to see invocation)
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202408040932.SqrqyXGU-lkp@xxxxxxxxx/
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>

Fixes: 42b54d52ecb7a819 ("clk: renesas: Add RZ/V2H(P) CPG driver")
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

As the issue is only present in renesas-clk, I will fold the fix into the
original commit.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds