Re: [PATCH net-next v2 1/3] ethtool: Extend cable testing interface with result source information

[Andrew Lunn]

On Tue, Aug 20, 2024 at 12:12:54PM +0200, Oleksij Rempel wrote:
> Extend the ethtool netlink cable testing interface by adding support for
> specifying the source of cable testing results. This allows users to
> differentiate between results obtained through different diagnostic
> methods.
> 
> For example, some TI 10BaseT1L PHYs provide two variants of cable
> diagnostics: Time Domain Reflectometry (TDR) and Active Link Cable
> Diagnostic (ALCD). By introducing `ETHTOOL_A_CABLE_RESULT_SRC` and
> `ETHTOOL_A_CABLE_FAULT_LENGTH_SRC` attributes, this update enables
> drivers to indicate whether the result was derived from TDR or ALCD,
> improving the clarity and utility of diagnostic information.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew