Re: [PATCH net-next v2 1/3] ethtool: Extend cable testing interface with result source information

From: Jakub Kicinski
Date: Tue Aug 20 2024 - 18:02:07 EST

Next message: Stephen Boyd: "Re: [PATCH 1/1] Driver: clk-qoriq.c: replace of_node_put with _free improves cleanup"
Previous message: Eric Chanudet: "Re: [PATCH] arm64: dts: ti: k3-j784s4-main: align watchdog clocks"
In reply to: Andrew Lunn: "Re: [PATCH net-next v2 1/3] ethtool: Extend cable testing interface with result source information"
Next in thread: Oleksij Rempel: "[PATCH net-next v2 3/3] phy: dp83td510: Utilize ALCD for cable length measurement when link is active"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, 20 Aug 2024 12:12:54 +0200 Oleksij Rempel wrote:
> + -
> + name: src
> + type: u8

If you have to respin please s/u8/u32/

Netlink rounds up all fields sizes to u32, u8 ends up being the same
size as u32 "on the wire" but 3 out of the 4 bytes are unusable.

Next message: Stephen Boyd: "Re: [PATCH 1/1] Driver: clk-qoriq.c: replace of_node_put with _free improves cleanup"
Previous message: Eric Chanudet: "Re: [PATCH] arm64: dts: ti: k3-j784s4-main: align watchdog clocks"
In reply to: Andrew Lunn: "Re: [PATCH net-next v2 1/3] ethtool: Extend cable testing interface with result source information"
Next in thread: Oleksij Rempel: "[PATCH net-next v2 3/3] phy: dp83td510: Utilize ALCD for cable length measurement when link is active"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]