Re: [PATCH 1/1] Driver: clk-qoriq.c: replace of_node_put with _free improves cleanup
From: Stephen Boyd
Date: Tue Aug 20 2024 - 18:03:34 EST
Quoting David Hunter (2024-08-19 18:35:49)
> Use the _free function to have automatic clean up instead of calling
How about:
Use __free() to have automatic cleanup instead of calling
of_node_put() manually.
> another function, of_node_put. This prevents leaking reference counts.
Are there any leaking reference counts? I'd just omit that sentence
unless there is one.
>
> The following commit has information on _free(device_node):
>
> 9448e55d032d99af8e23487f51a542d51b2f1a48
>
> The code was able to compile without errors or warnings.
The rest of this can go below the triple dash ---