Re: [PATCH v4 1/6] i3c: mipi-i3c-hci: Add AMDI5017 ACPI ID to the I3C Support List

[Andy Shevchenko]

On Wed, Aug 21, 2024 at 07:07:45PM +0530, Shyam Sundar S K wrote:
> + Andy

Thank you!

> On 8/21/2024 19:05, Shyam Sundar S K wrote:
> > The current driver code lacks the necessary plumbing for ACPI IDs,
> > preventing the mipi-i3c-hci driver from being loaded on x86
> > platforms that advertise I3C ACPI support.
> > 
> > This update adds the AMDI5017 ACPI ID to the list of supported IDs.

Please, provide a DSDT excerpt to show how it will look like in the ACPI
tables.

...

> > +static const struct acpi_device_id i3c_hci_acpi_match[] = {
> > +	{"AMDI5017"},

Spaces are missing

	{ "AMDI5017" },

> > +	{}
> > +};
> > +MODULE_DEVICE_TABLE(acpi, i3c_hci_acpi_match);

...

Otherwise LGTM, thanks!

-- 
With Best Regards,
Andy Shevchenko