Re: [PATCH v4 1/6] i3c: mipi-i3c-hci: Add AMDI5017 ACPI ID to the I3C Support List
From: Shyam Sundar S K
Date: Wed Aug 21 2024 - 11:14:34 EST
On 8/21/2024 19:26, Andy Shevchenko wrote:
> On Wed, Aug 21, 2024 at 07:07:45PM +0530, Shyam Sundar S K wrote:
>> + Andy
>
> Thank you!
>
>> On 8/21/2024 19:05, Shyam Sundar S K wrote:
>>> The current driver code lacks the necessary plumbing for ACPI IDs,
>>> preventing the mipi-i3c-hci driver from being loaded on x86
>>> platforms that advertise I3C ACPI support.
>>>
>>> This update adds the AMDI5017 ACPI ID to the list of supported IDs.
>
> Please, provide a DSDT excerpt to show how it will look like in the ACPI
> tables.
Scope (_SB)
{
...
Name (HCID, "AMDI5017")
Device (I3CA)
{
Method (_HID, 0, Serialized) // _HID: Hardware ID
{
If ((I30M == Zero))
{
If (CondRefOf (HCIB))
{
Return (HCID) /* \_SB_.HCID */
}
Else
{
Return (I3ID) /* \_SB_.I3ID */
}
}
Else
{
Return (I2ID) /* \_SB_.I2ID */
}
}
...
}
>
> ...
>
>>> +static const struct acpi_device_id i3c_hci_acpi_match[] = {
>>> + {"AMDI5017"},
>
> Spaces are missing
>
> { "AMDI5017" },
OK. Will change it.
>
>>> + {}
>>> +};
>>> +MODULE_DEVICE_TABLE(acpi, i3c_hci_acpi_match);
>
> ...
>
> Otherwise LGTM, thanks!
>
Thanks,
Shyam