Re: [PATCH v1] mm: Defines obj_cgroup_get() if CONFIG_MEMCG is not defined.
From: Michal Hocko
Date: Wed Aug 21 2024 - 11:14:22 EST
On Tue 20-08-24 12:50:05, Kanchana P Sridhar wrote:
> This resolves an issue with obj_cgroup_get() not being defined
> if CONFIG_MEMCG is not defined.
Could you paste the compilation error and which tree this is based on?
> This causes build errors if
> obj_cgroup_get() is called from code that is agnostic of CONFIG_MEMCG.
>
> The patch resolves this.
>
> Signed-off-by: Kanchana P Sridhar <kanchana.p.sridhar@xxxxxxxxx>
> ---
> include/linux/memcontrol.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index fe05fdb92779..f693d254ab2a 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -1281,6 +1281,10 @@ struct mem_cgroup *mem_cgroup_from_css(struct cgroup_subsys_state *css)
> return NULL;
> }
>
> +static inline void obj_cgroup_get(struct obj_cgroup *objcg)
> +{
> +}
> +
> static inline void obj_cgroup_put(struct obj_cgroup *objcg)
> {
> }
>
> base-commit: 7d0b0d4b77b368b2111fc8b4449e33dfb3c34087
> --
> 2.27.0
>
--
Michal Hocko
SUSE Labs