Re: [PATCH v4] hid-playstation: DS4: Update rumble and lightbar together

From: Jiri Kosina
Date: Wed Aug 21 2024 - 10:33:40 EST


On Tue, 20 Aug 2024, Max Staudt wrote:

> Some 3rd party gamepads expect updates to rumble and lightbar together,
> and setting one may cancel the other.
>
> Let's maximise compatibility for these controllers by sending rumble
> and lightbar updates together, even when only one has been scheduled.
>
> The quirky controllers are matched by a known CRC32 over their HID
> report descriptor (hdev->rdesc), since they seem to share the same
> descriptor, while pretending to be a Sony DS4 v2.0.
>
> Signed-off-by: Max Staudt <max@xxxxxxxxx>

Roderick, does you Ack from v2 still hold?

Thanks,

--
Jiri Kosina
SUSE Labs