Re: [PATCH v4] hid-playstation: DS4: Update rumble and lightbar together
From: Roderick Colenbrander
Date: Wed Aug 21 2024 - 11:04:10 EST
On Wed, Aug 21, 2024 at 7:33 AM Jiri Kosina <jikos@xxxxxxxxxx> wrote:
>
> On Tue, 20 Aug 2024, Max Staudt wrote:
>
> > Some 3rd party gamepads expect updates to rumble and lightbar together,
> > and setting one may cancel the other.
> >
> > Let's maximise compatibility for these controllers by sending rumble
> > and lightbar updates together, even when only one has been scheduled.
> >
> > The quirky controllers are matched by a known CRC32 over their HID
> > report descriptor (hdev->rdesc), since they seem to share the same
> > descriptor, while pretending to be a Sony DS4 v2.0.
> >
> > Signed-off-by: Max Staudt <max@xxxxxxxxx>
>
> Roderick, does you Ack from v2 still hold?
Ideally I would like some type of quirk, but I have no good way of
verifying (also across different 'clone' devices) how reliable this
current check would be. It feels a bit too much towards a magical
value. I don't see why the reports would differ besides some engineer
having made a typo.
My gut feeling is that the previous fix is less fragile, so let's opt
for that one.
Roderick
>
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>
>