Re: [PATCH] net: phy: realtek: Fix setting of PHY LEDs Mode B bit on RTL8211F

From: Paolo Abeni
Date: Thu Aug 22 2024 - 07:02:49 EST




On 8/21/24 04:16, Sava Jakovljev wrote:
From: Sava Jakovljev <savaj@xxxxxxxxxxxxxx>

The current implementation incorrectly sets the mode bit of the PHY chip.
Bit 15 (RTL8211F_LEDCR_MODE) should not be shifted together with the
configuration nibble of a LED- it should be set independently of the
index of the LED being configured.
As a consequence, the RTL8211F LED control is actually operating in Mode A.
Fix the error by or-ing final register value to write with a const-value of
RTL8211F_LEDCR_MODE, thus setting Mode bit explicitly.

Fixes: 17784801d888 ("net: phy: realtek: Add support for PHY LEDs on RTL8211F")

Please, do not insert blank lines in the tag area i.e. between the fixes and sob tags.

I'll one-off fix this while applying the patch,

No need to resent

Cheers,

Paolo