Re: [PATCH 13/13] media: qcom: camss: Add support for VFE hardware version Titan 780

[Vladimir Zapolskiy]

On 8/21/24 14:11, Vladimir Zapolskiy wrote:
> On 8/12/24 17:41, Depeng Shao wrote:
> > Add support for VFE found on SM8550 (Titan 780). This implementation is
> > based on the titan 480 implementation. It supports the normal and lite
> > VFE.
> >
> > Co-developed-by: Yongsheng Li <quic_yon@xxxxxxxxxxx>
> > Signed-off-by: Yongsheng Li <quic_yon@xxxxxxxxxxx>
> > Signed-off-by: Depeng Shao <quic_depengs@xxxxxxxxxxx>
> > ---
>
> <snip>
>
> > +
> > +static void vfe_reg_update(struct vfe_device *vfe, enum vfe_line_id line_id)
> > +{
> > +	int port_id = line_id;
> > +
> > +	/* RUP(register update) registers has beem moved to CSID in Titan 780.
> > +	 * Notify the event of trigger RUP.
> > +	 */
> > +	camss_reg_update(vfe->camss, vfe->id, port_id, false);
> > +}
> > +
> > +static inline void vfe_reg_update_clear(struct vfe_device *vfe,
> > +					enum vfe_line_id line_id)
> > +{
> > +	int port_id = line_id;
>
> Once I said that the comment with a typo can be removed from these two
> functions, however the functions can be removed, since they are trivial,
> use camss_reg_update(vfe->camss, vfe->id, port_id, ...) directly in the code.

I see that these new vfe_reg_update() and vfe_reg_update_clear() are
callback functions now, so, without making a step back, now it will not
be straightforward to get rid of one more level of indirection.

Just remove the comments then.

> > +
> > +	/* RUP(register update) registers has beem moved to CSID in Titan 780.
> > +	 * Notify the event of trigger RUP clear.
> > +	 */
> > +	camss_reg_update(vfe->camss, vfe->id, port_id, true);
> > +}
> > +

--
Best wishes,
Vladimir