RE: [PATCH v1] spi: nxp-fspi: Use min macro

[Bough Chen]

> -----Original Message-----
> From: Yan Zhen <yanzhen@xxxxxxxx>
> Sent: 2024年8月27日 16:58
> To: Han Xu <han.xu@xxxxxxx>; Bough Chen <haibo.chen@xxxxxxx>;
> broonie@xxxxxxxxxx
> Cc: yogeshgaur.83@xxxxxxxxx; linux-spi@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; opensource.kernel@xxxxxxxx; Yan Zhen
> <yanzhen@xxxxxxxx>
> Subject: [PATCH v1] spi: nxp-fspi: Use min macro
> 
> When the original file is guaranteed to contain the minmax.h header file and
> compile correctly, using the real macro is usually more intuitive and readable.
> 
> Signed-off-by: Yan Zhen <yanzhen@xxxxxxxx>
> ---
>  drivers/spi/spi-nxp-fspi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c index
> 88397f712a3b..fda902aa5815 100644
> --- a/drivers/spi/spi-nxp-fspi.c
> +++ b/drivers/spi/spi-nxp-fspi.c
> @@ -756,8 +756,7 @@ static int nxp_fspi_read_ahb(struct nxp_fspi *f, const
> struct spi_mem_op *op)
>  			iounmap(f->ahb_addr);
> 
>  		f->memmap_start = start;
> -		f->memmap_len = len > NXP_FSPI_MIN_IOMAP ?
> -				len : NXP_FSPI_MIN_IOMAP;
> +		f->memmap_len = max(len, NXP_FSPI_MIN_IOMAP);

Reviewed-by: Haibo Chen <haibo.chen@xxxxxxx>

Thanks!
Haibo Chen
> 
>  		f->ahb_addr = ioremap(f->memmap_phy + f->memmap_start,
>  					 f->memmap_len);
> --
> 2.34.1