Re: [PATCH v1] spi: nxp-fspi: Use min macro

[Michael Walle]

Hi,

On Tue Aug 27, 2024 at 10:57 AM CEST, Yan Zhen wrote:
> When the original file is guaranteed to contain the minmax.h header file
> and compile correctly, using the real macro is usually 
> more intuitive and readable.

The subject doesn't match what you're doing here. Also, shouldn't
one use max_t()?

-michael

>
> Signed-off-by: Yan Zhen <yanzhen@xxxxxxxx>
> ---
>  drivers/spi/spi-nxp-fspi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c
> index 88397f712a3b..fda902aa5815 100644
> --- a/drivers/spi/spi-nxp-fspi.c
> +++ b/drivers/spi/spi-nxp-fspi.c
> @@ -756,8 +756,7 @@ static int nxp_fspi_read_ahb(struct nxp_fspi *f, const struct spi_mem_op *op)
>  			iounmap(f->ahb_addr);
>  
>  		f->memmap_start = start;
> -		f->memmap_len = len > NXP_FSPI_MIN_IOMAP ?
> -				len : NXP_FSPI_MIN_IOMAP;
> +		f->memmap_len = max(len, NXP_FSPI_MIN_IOMAP);
>  
>  		f->ahb_addr = ioremap(f->memmap_phy + f->memmap_start,
>  					 f->memmap_len);

Attachment: signature.asc
Description: PGP signature