Re: [PATCH 03/16] arm64: dts: qcom: sc7180: change labels to lower-case
From: Krzysztof Kozlowski
Date: Wed Aug 28 2024 - 07:13:50 EST
On 28/08/2024 12:53, Konrad Dybcio wrote:
> On 28.08.2024 9:17 AM, Krzysztof Kozlowski wrote:
>> DTS coding style expects labels to be lowercase. No functional impact.
>> Verified with comparing decompiled DTB (dtx_diff and fdtdump+diff).
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> ---
>> arch/arm64/boot/dts/qcom/sc7180-firmware-tfa.dtsi | 84 ++---
>> .../arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 8 +-
>> .../boot/dts/qcom/sc7180-trogdor-homestar.dtsi | 8 +-
>> .../boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi | 8 +-
>> arch/arm64/boot/dts/qcom/sc7180.dtsi | 344 ++++++++++-----------
>> arch/arm64/boot/dts/qcom/sm7125.dtsi | 16 +-
>> 6 files changed, 234 insertions(+), 234 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7180-firmware-tfa.dtsi b/arch/arm64/boot/dts/qcom/sc7180-firmware-tfa.dtsi
>> index ee35a454dbf6..f362b6b436ce 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7180-firmware-tfa.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7180-firmware-tfa.dtsi
>> @@ -6,82 +6,82 @@
>> * by Qualcomm firmware.
>> */
>>
>> -&CPU0 {
>> +&cpu0 {
>> /delete-property/ power-domains;
>> /delete-property/ power-domain-names;
>>
>> - cpu-idle-states = <&LITTLE_CPU_SLEEP_0
>> - &LITTLE_CPU_SLEEP_1
>> - &CLUSTER_SLEEP_0>;
>> + cpu-idle-states = <&LITTLE_cpu_sleep_0
>> + &LITTLE_cpu_sleep_1
>> + &cluster_sleep_0>;
>
> I suppose this wasn't intended
Yeah, I need to improve the pattern. Thanks for finding this.
Best regards,
Krzysztof