Re: [PATCH] net: dsa: microchip: Use standard regmap locking

From: Mark Brown
Date: Wed Aug 28 2024 - 07:14:09 EST


On Tue, Aug 27, 2024 at 02:54:52PM +0200, Paolo Abeni wrote:
> On 8/22/24 21:53, Mark Brown wrote:
> > For unclear reasons the ksz drivers use custom regmap locking which is
> > simply a wrapper around a standard mutex.
>
> According to the commit introducing such lock,
> 013572a236ef53cbd1e315e0acf2ee632cc816d4
> the ksz driver family one regmap per register width (8/16/32), accessing the
> same set of registers.
>
> The locking implemented with the code removed here allows serializing
> operations using different register widths.

This really could use a comment somewhere.

Attachment: signature.asc
Description: PGP signature