Re: [PATCH 16/22] dt-bindings: qcom: geni-se: document support for SA8255P

From: Krzysztof Kozlowski
Date: Thu Aug 29 2024 - 03:42:42 EST


On Wed, Aug 28, 2024 at 01:37:15PM -0700, Nikunj Kela wrote:
> Add "qcom,sa8255p-geni-se-qup" compatible for representing QUP on
> SA8255p.
>
> Clocks are being managed by the firmware VM and not required on
> SA8255p Linux VM hence removing it from required list.
>
> CC: Praveen Talari <quic_ptalari@xxxxxxxxxxx>
> Signed-off-by: Nikunj Kela <quic_nkela@xxxxxxxxxxx>
> ---
> .../bindings/soc/qcom/qcom,geni-se.yaml | 47 +++++++++++++++++--
> 1 file changed, 43 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
> index 7b031ef09669..40e3a3e045da 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
> @@ -22,17 +22,16 @@ properties:
> enum:
> - qcom,geni-se-qup
> - qcom,geni-se-i2c-master-hub
> + - qcom,sa8255p-geni-se-qup

Same problems. If you decide to use generic compatibles, it means it
covers all devices. Otherwise it does not make any sense.

>
> reg:
> description: QUP wrapper common register address and length.
> maxItems: 1
>
> clock-names:
> - minItems: 1

Huh?

Best regards,
Krzysztof