Re: [PATCH 19/22] dt-bindings: i2c: document support for SA8255p

[Krzysztof Kozlowski]

On Wed, Aug 28, 2024 at 01:37:18PM -0700, Nikunj Kela wrote:
> Add compatible representing i2c support on SA8255p.
> 
> Clocks and interconnects are being configured in Firmware VM
> on SA8255p, therefore making them optional.
> 
> CC: Praveen Talari <quic_ptalari@xxxxxxxxxxx>
> Signed-off-by: Nikunj Kela <quic_nkela@xxxxxxxxxxx>
> ---
>  .../bindings/i2c/qcom,i2c-geni-qcom.yaml      | 56 ++++++++++++-------
>  1 file changed, 36 insertions(+), 20 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml
> index 9f66a3bb1f80..88f513fc5b08 100644
> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml
> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml
> @@ -15,14 +15,13 @@ properties:
>      enum:
>        - qcom,geni-i2c
>        - qcom,geni-i2c-master-hub
> +      - qcom,sa8255p-geni-i2c

Same as in other patches, this does not make sense. What is the point of
generic compatibles?


>  
>    clocks:
> -    minItems: 1
> -    maxItems: 2

Nope.

> +    description: phandles for the clock providers

Useless description. This cannot be anything else than phandles for the
clock providers.

Best regards,
Krzysztof