Re: [PATCH] dpaa2-switch: fix flooding domain among multiple vlans

From: kernel test robot
Date: Thu Aug 29 2024 - 14:14:48 EST


Hi Wan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.11-rc5 next-20240829]
[cannot apply to horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Wan-Junjie/dpaa2-switch-fix-flooding-domain-among-multiple-vlans/20240827-191121
base: linus/master
patch link: https://lore.kernel.org/r/20240827110855.3186502-1-junjie.wan%40inceptio.ai
patch subject: [PATCH] dpaa2-switch: fix flooding domain among multiple vlans
config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20240830/202408300142.EN2CiiIs-lkp@xxxxxxxxx/config)
compiler: arm-linux-gnueabi-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240830/202408300142.EN2CiiIs-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408300142.EN2CiiIs-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c: In function 'dpaa2_switch_fdb_set_egress_flood':
>> drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c:179:18: warning: unused variable 'i' [-Wunused-variable]
179 | int err, i;
| ^
drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c: In function 'dpaa2_switch_port_flood':
>> drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c:1782:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
1782 | if (err)
| ^~
drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c:1784:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
1784 | return err;
| ^~~~~~


vim +/i +179 drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c

175
176 static int dpaa2_switch_fdb_set_egress_flood(struct ethsw_core *ethsw, u16 fdb_id)
177 {
178 struct dpsw_egress_flood_cfg flood_cfg;
> 179 int err, i;
180
181 /* Setup broadcast flooding domain */
182 dpaa2_switch_fdb_get_flood_cfg(ethsw, fdb_id, DPSW_BROADCAST, &flood_cfg);
183 err = dpsw_set_egress_flood(ethsw->mc_io, 0, ethsw->dpsw_handle,
184 &flood_cfg);
185 if (err) {
186 dev_err(ethsw->dev, "dpsw_set_egress_flood() = %d\n", err);
187 return err;
188 }
189
190 /* Setup unknown flooding domain */
191 dpaa2_switch_fdb_get_flood_cfg(ethsw, fdb_id, DPSW_FLOODING, &flood_cfg);
192 err = dpsw_set_egress_flood(ethsw->mc_io, 0, ethsw->dpsw_handle,
193 &flood_cfg);
194 if (err) {
195 dev_err(ethsw->dev, "dpsw_set_egress_flood() = %d\n", err);
196 return err;
197 }
198
199 return 0;
200 }
201

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki