Re: [PATCH] dpaa2-switch: fix flooding domain among multiple vlans
From: kernel test robot
Date: Fri Aug 30 2024 - 17:37:53 EST
Hi Wan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.11-rc5 next-20240830]
[cannot apply to horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Wan-Junjie/dpaa2-switch-fix-flooding-domain-among-multiple-vlans/20240827-191121
base: linus/master
patch link: https://lore.kernel.org/r/20240827110855.3186502-1-junjie.wan%40inceptio.ai
patch subject: [PATCH] dpaa2-switch: fix flooding domain among multiple vlans
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240831/202408310505.RxA0GVcf-lkp@xxxxxxxxx/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240831/202408310505.RxA0GVcf-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408310505.RxA0GVcf-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c:179:11: warning: unused variable 'i' [-Wunused-variable]
179 | int err, i;
| ^
>> drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c:1784:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
1784 | return err;
| ^
drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c:1782:2: note: previous statement is here
1782 | if (err)
| ^
2 warnings generated.
vim +/if +1784 drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c
1766
1767 static int dpaa2_switch_port_flood(struct ethsw_port_priv *port_priv,
1768 struct switchdev_brport_flags flags)
1769 {
1770 struct ethsw_core *ethsw = port_priv->ethsw_data;
1771 struct net_device *netdev = port_priv->netdev;
1772 int err;
1773
1774 if (flags.mask & BR_BCAST_FLOOD)
1775 port_priv->bcast_flood = !!(flags.val & BR_BCAST_FLOOD);
1776
1777 if (flags.mask & BR_FLOOD)
1778 port_priv->ucast_flood = !!(flags.val & BR_FLOOD);
1779
1780 /* Recreate the egress flood domain of every vlan domain */
1781 err = vlan_for_each(netdev, dpaa2_switch_port_flood_vlan, netdev);
1782 if (err)
1783 netdev_err(netdev, "Unable to restore vlan flood err (%d)\n", err);
> 1784 return err;
1785
1786 return dpaa2_switch_fdb_set_egress_flood(ethsw, port_priv->fdb->fdb_id);
1787 }
1788
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki