Re: [PATCH] Revert "misc: fastrpc: Restrict untrusted app to attach to privileged PD"
From: Dmitry Baryshkov
Date: Fri Aug 30 2024 - 03:51:34 EST
On Thu, Aug 15, 2024 at 03:55:01PM GMT, Srinivas Kandagatla wrote:
>
>
> On 15/08/2024 10:49, Griffin Kroah-Hartman wrote:
> > This reverts commit bab2f5e8fd5d2f759db26b78d9db57412888f187.
> >
> > Joel reported that this commit breaks userspace and stops sensors in
> > SDM845 from working. Also breaks other qcom SoC devices running postmarketOS.
> >
> > Cc: stable <stable@xxxxxxxxxx>
> > Cc: Ekansh Gupta <quic_ekangupt@xxxxxxxxxxx>
> > Cc: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > Cc: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Reported-by: Joel Selvaraj <joelselvaraj.oss@xxxxxxxxx>
> > Link: https://lore.kernel.org/r/9a9f5646-a554-4b65-8122-d212bb665c81@xxxxxxxxxxxx
> > Signed-off-by: Griffin Kroah-Hartman <griffin@xxxxxxxxx>
> > ---
>
>
> Lets fix this properly by updating existing device tree entries and bindings
> to enforce misuse of "qcom,non-secure-domain" on all Qcom SoC's.
It is not possible. We must remain compatible with existing DTs.
>
> As this patch is only doing part of the job and breaking existing platforms,
>
> Acked-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
>
> --srini
>
>
>
--
With best wishes
Dmitry