Re: [PATCH v2 02/19] gendwarfksyms: Add symbol list handling

[Masahiro Yamada]

On Fri, Aug 16, 2024 at 2:39 AM Sami Tolvanen <samitolvanen@xxxxxxxxxx> wrote:
>
> Add support for passing a list of exported symbols to gendwarfksyms
> via stdin and filter out non-exported symbols from the output.
>
> Signed-off-by: Sami Tolvanen <samitolvanen@xxxxxxxxxx>
> ---

>   */
> @@ -40,7 +82,7 @@ int process_die_container(struct state *state, Dwarf_Die *die,
>  }
>
>  /*
> - * Symbol processing
> + * Exported symbol processing
>   */
>  static int process_subprogram(struct state *state, Dwarf_Die *die)
>  {


I also tend to regard this kind comment line change as a noise.



I think you can squash 02/19 into 01/19 because
this tool does not do anything useful at this point.




-- 
Best Regards
Masahiro Yamada