Re: [PATCH v2 02/19] gendwarfksyms: Add symbol list handling

From: Sami Tolvanen
Date: Wed Sep 04 2024 - 16:52:10 EST


On Sun, Sep 1, 2024 at 11:00 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
>
> On Fri, Aug 16, 2024 at 2:39 AM Sami Tolvanen <samitolvanen@xxxxxxxxxx> wrote:
> >
> > /*
> > - * Symbol processing
> > + * Exported symbol processing
> > */
> > static int process_subprogram(struct state *state, Dwarf_Die *die)
> > {
>
>
> I also tend to regard this kind comment line change as a noise.
>
>
>
> I think you can squash 02/19 into 01/19 because
> this tool does not do anything useful at this point.

Yes, that makes sense. I'll squash these in v3.

Sami