[PATCH v3 5/7] media: i2c: imx290: Avoid communication during probe()
From: bbara93
Date: Mon Sep 02 2024 - 11:58:36 EST
From: Benjamin Bara <benjamin.bara@xxxxxxxxxxx>
As we don't know the mode during probe(), it doesn't make sense to
update the sensors' registers with assumptions. Avoid the communication
in this case.
Signed-off-by: Benjamin Bara <benjamin.bara@xxxxxxxxxxx>
---
Changes since v2:
- new
---
drivers/media/i2c/imx290.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
index ece4d66001f5..9610e9fd2059 100644
--- a/drivers/media/i2c/imx290.c
+++ b/drivers/media/i2c/imx290.c
@@ -769,6 +769,10 @@ static int imx290_set_ctrl(struct v4l2_ctrl *ctrl)
if (!pm_runtime_get_if_in_use(imx290->dev))
return 0;
+ /* V4L2 controls values will be applied only when mode is known */
+ if (imx290->current_mode == &imx290_mode_off)
+ return 0;
+
state = v4l2_subdev_get_locked_active_state(&imx290->sd);
format = v4l2_subdev_state_get_format(state, 0);
--
2.46.0