Re: [PATCH -next] serial: 8250_aspeed_vuart: Enable module autoloading

From: Andy Shevchenko
Date: Tue Sep 03 2024 - 12:19:22 EST


On Tue, Sep 03, 2024 at 05:49:54PM +0200, Uwe Kleine-König wrote:
> On Tue, Sep 03, 2024 at 01:15:03PM +0000, Liao Chen wrote:

...

> I wonder if you found this entry missing by code review, or if you have
> a machine with that UART and so you actually benefit.

Using arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts in QEMU
I never experienced an issue. Seems due to defconfig having it =y.
(used arch/arm/configs/aspeed_g5_defconfig)

> Otherwise looks right to me.
>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx>

--
With Best Regards,
Andy Shevchenko