Re: [PATCH -next] serial: 8250_aspeed_vuart: Enable module autoloading

[liaochen (A)]

On 2024/9/3 23:49, Uwe Kleine-König wrote:
> Hello,
>
> On Tue, Sep 03, 2024 at 01:15:03PM +0000, Liao Chen wrote:
> > Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based
> > on the alias from of_device_id table.
> >
> > Signed-off-by: Liao Chen <liaochen4@xxxxxxxxxx>
> > ---
> >   drivers/tty/serial/8250/8250_aspeed_vuart.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/tty/serial/8250/8250_aspeed_vuart.c b/drivers/tty/serial/8250/8250_aspeed_vuart.c
> > index 53d8eee9b1c8..25c201cfb91e 100644
> > --- a/drivers/tty/serial/8250/8250_aspeed_vuart.c
> > +++ b/drivers/tty/serial/8250/8250_aspeed_vuart.c
> > @@ -561,6 +561,7 @@ static const struct of_device_id aspeed_vuart_table[] = {
> >   	{ .compatible = "aspeed,ast2500-vuart" },
> >   	{ },
> >   };
> > +MODULE_DEVICE_TABLE(of, aspeed_vuart_table);
>
> I wonder if you found this entry missing by code review, or if you have
> a machine with that UART and so you actually benefit.

I found it from code review. Since this device could be compiled as a 
module, I think it is better to add this entry.

Thanks,
Chen

> Otherwise looks right to me.
>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx>
>
> Best regards
> Uwe