RE: [PATCH v1 1/2] dt-bindings: clock: nxp,imx95-blk-ctl: Add compatible string for i.MX95 HSIO BLK CTRL

[Hongxing Zhu]

> -----Original Message-----
> From: Fabio Estevam <festevam@xxxxxxxxx>
> Sent: 2024年9月3日 21:02
> To: Hongxing Zhu <hongxing.zhu@xxxxxxx>
> Cc: abelvesa@xxxxxxxxxx; Peng Fan <peng.fan@xxxxxxx>;
> mturquette@xxxxxxxxxxxx; sboyd@xxxxxxxxxx; shawnguo@xxxxxxxxxx;
> s.hauer@xxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx;
> imx@xxxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx
> Subject: Re: [PATCH v1 1/2] dt-bindings: clock: nxp,imx95-blk-ctl: Add
> compatible string for i.MX95 HSIO BLK CTRL
> 
> Hi Richard,
> 
> On Tue, Sep 3, 2024 at 5:21 AM Richard Zhu <hongxing.zhu@xxxxxxx> wrote:
> >
> > Add compatible string "nxp,imx95-hsio-blk-ctl" for iMX95.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@xxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git
> a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
> b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
> > index 2dffc02dcd8b..638241f6749f 100644
> > --- a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
> > +++ b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
> > @@ -17,6 +17,7 @@ properties:
> >            - nxp,imx95-display-csr
> >            - nxp,imx95-camera-csr
> >            - nxp,imx95-vpu-csr
> > +          - nxp,imx95-hsio-blk-ctl
> 
> Please keep the entries in alphabetical order.

Thanks for your comments.
I follow the time-sequence to add the changes before.

In current compatible items, the alphabetical order is already messed-up.
How do you think about the following one?

--- a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
+++ b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml
@@ -16,6 +16,7 @@ properties:
           - nxp,imx95-lvds-csr
           - nxp,imx95-display-csr
           - nxp,imx95-camera-csr
+          - nxp,imx95-hsio-blk-ctl
           - nxp,imx95-vpu-csr
       - const: syscon

Best Regards
Richard Zhu