Re: [PATCH 04/13] media: qcom: camss: csiphy: Add an init callback to CSI PHY devices

[Depeng Shao]

Hi Bryan,

On 8/19/2024 8:17 AM, Vladimir Zapolskiy wrote:
> On 8/12/24 17:41, Depeng Shao wrote:
> > From: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>

> I've already expressed concerns about a necessity of this function, 
> since it
> adds runtime burden of work, which can be successfully done at compile 
> time,
> but okay...
>
> Since it is needed for 3PH case only, it may make sense to remove it 
> from 2PH
> and call it here conditionally like
>
>      if (csiphy->res->hw_ops->init)
>          ret = csiphy->res->hw_ops->init(csiphy);
>
> But it's up to you, I hope the callback will be removed in short future.

Could you please comment on if it is fine to remove the init from 2PH 
driver?


Thanks,
Depeng