Re: [PATCH next] iommu/tegra241-cmdqv: Fix ioremap() error handling in probe()

[Nicolin Chen]

On Wed, Sep 04, 2024 at 11:02:43AM +0300, Dan Carpenter wrote:
> The ioremap() function doesn't return error pointers, it returns NULL
> on error so update the error handling.  Also just return directly
> instead of calling iounmap() on the NULL pointer.  Calling
> iounmap(NULL) doesn't cause a problem on ARM but on other architectures
> it can trigger a warning so it'a bad habbit.
> 
> Fixes: 918eb5c856f6 ("iommu/arm-smmu-v3: Add in-kernel support for NVIDIA Tegra241 (Grace) CMDQV")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Reviewed-by: Nicolin Chen <nicolinc@xxxxxxxxxx>

Thanks!