Re: [PATCH 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568

[Chukun Pan]

Hi Junhao,

>>> +	vcc5v0_usb_modem: regulator-5v0-vcc-usb-modem {
>> 
>> Are you sure this regulator is 5v?
>> 
>
> It should actually be 3.3V, I will fix it and rename
> to vcc3v3_usb_modem

I prefer vcc3v3_rf or vcc3v3_ngff,
this is closer to the schematics.

>>> +	pinctrl-names = "default";
>>> +	pinctrl-0 = <&pcie30x2m1_pins>;
>> 
>> These are actually pcie30x1m0_pins.
>
> pcie30x1m0_pins seems to conflict with sdmmc0,
> I changed it to pcie30x1m1_pins

This is obviously incorrect. I didn't notice that
your pinctrl for sdmmc0 is wrong.
(Because the cd pin are different)
The sdmmc0 node should be like this:

&sdmmc0 {
	bus-width = <4>;
	cap-sd-highspeed;
	cd-gpios = <&gpio0 RK_PB5 GPIO_ACTIVE_LOW>;
	disable-wp;
	no-1-8-v;
	pinctrl-names = "default";
	pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd>;
	vmmc-supply = <&vcc3v3_sd>;
	vqmmc-supply = <&vcc_3v3>;
	status = "okay";
};

-- 
2.25.1