Re: [PATCH -v2] Resource: fix region_intersects() for CXL memory
From: Andy Shevchenko
Date: Thu Sep 05 2024 - 06:56:34 EST
On Wed, Sep 04, 2024 at 04:58:20PM -0700, Dan Williams wrote:
> Huang, Ying wrote:
> > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes:
[..]
> > > You may move Cc list after '---', so it won't unnecessarily pollute the commit
> > > message.
> >
> > Emm... It appears that it's a common practice to include "Cc" in the
> > commit log.
>
> Yes, just ignore this feedback, it goes against common practice. Cc list
> as is looks sane to me.
It seems nobody can give technical arguments why it's better than just keeping
them outside of the commit message. Mantra "common practice" nowadays is
questionable.
--
With Best Regards,
Andy Shevchenko