Re: [RFC PATCH 00/12] media: ov5645: Add support for streams
From: Tomi Valkeinen
Date: Thu Sep 05 2024 - 06:57:50 EST
On 05/09/2024 13:51, Lad, Prabhakar wrote:
Hi Tomi,
On Thu, Sep 5, 2024 at 11:29 AM Tomi Valkeinen
<tomi.valkeinen@xxxxxxxxxxxxxxxx> wrote:
On 05/09/2024 13:27, Lad, Prabhakar wrote:
Hi Tomi,
On Thu, Sep 5, 2024 at 10:11 AM Tomi Valkeinen
<tomi.valkeinen@xxxxxxxxxxxxxxxx> wrote:
<snip>
I think you actually want 1/0->0/0 routing. The error says that the sink
side device has routing which does not have a stream at stream ID 1, or
no routing support at all, which implies a single stream at stream ID 0.
Looking at patch 12, there's something wrong with the approach here. Are
you perhaps trying to define the CSI-2 VC with the streams?
Yes, based on the previous feedback received, I am implementing
virtual channels as streams. If this isn't the correct approach can
you please guide me on what we should be using to support virtual
channels?
Can you describe what kind of hardware you have and how the VCs are
supposed to be configured and used there?
__________________ ______________
_____________________
| | |
| |
|
| OV5645 Sensor | | RZ/G2L CSI2 |
| RZ/G2L CRU |
| 1ch out of 4x VC |---------------> | 4x VC
|-------------->| 1Ch capture out 4xVC |
|__________________| |_____________|
|____________________|
The formatting there is quite broken, but afaiu you have a standard
setup with single stream. Then it should be as I wrote earlier: a single
hardcoded 1/0->0/0 route in the sensor, and .get_frame_desc() returns VC
0 and a suitable DT for that stream.
When you say "implementing virtual channels as streams", what is the
feature/requirement you are looking at? Do you have some specific need
to use other VCs than 0?
Tomi