Re: [PATCH v3 4/4] arm64: dts: qcom: sc8280xp-x13s: keep less regulators always-on

From: Johan Hovold
Date: Fri Sep 06 2024 - 10:49:29 EST


On Thu, Sep 05, 2024 at 10:27:24PM +0300, Dmitry Baryshkov wrote:
> On Thu, Sep 05, 2024 at 08:23:39PM GMT, Bartosz Golaszewski wrote:
> > On Thu, Sep 5, 2024 at 4:04 PM Johan Hovold <johan@xxxxxxxxxx> wrote:
> > > On Thu, Sep 05, 2024 at 02:20:22PM +0200, Bartosz Golaszewski wrote:
> > > > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> > > >
> > > > Remove the regulator-always-on property from the ones that used to be
> > > > implicitly needed by the on-board WCN6855 now that its PMU is modeled in
> > > > device-tree.

> > > What makes you think s10b is only used by wcn6855?
> >
> > I didn't say that. It's used by many components but they seem to be
> > all described in DT. But I get it, the schematics show it in so many
> > places, it would be risky to not keep it on.
>
> Well, that depends on the consumers. If all consumers are good and
> voting, then it should be safe.

Right. But in this case, not all consumers are described in DT (e.g.
ddr) and this is effectively an always-on rail.

Johan