Re: [PATCH v2 8/9] dt-bindings: phy: sparx5: document lan969x

From: Daniel Machon
Date: Tue Sep 10 2024 - 05:00:51 EST


> > maintainers:
> > - Steen Hegelund <steen.hegelund@xxxxxxxxxxxxx>
> > + - Daniel Machon <daniel.machon@xxxxxxxxxxxxx>
> >
> > description: |
> > The Sparx5 SERDES interfaces share the same basic functionality, but
> > @@ -62,12 +63,26 @@ description: |
> > * 10.3125 Gbps (10GBASE-R/10GBASE-KR/USXGMII)
> > * 25.78125 Gbps (25GBASE-KR/25GBASE-CR/25GBASE-SR/25GBASE-LR/25GBASE-ER)
> >
> > + lan969x has ten SERDES10G interfaces that share the same features, operating
> > + modes and data rates as the equivalent Sparx5 SERDES10G interfaces.
> > +
> > properties:
> > $nodename:
> > pattern: "^serdes@[0-9a-f]+$"
> >
> > compatible:
> > - const: microchip,sparx5-serdes
> > + oneOf:
> > + - enum:
> > + - microchip,sparx5-serdes
> > + - microchip,lan9691-serdes
> > + - items:
> > + - enum:
> > + - microchip,lan9698-serdes
> > + - microchip,lan9696-serdes
> > + - microchip,lan9694-serdes
> > + - microchip,lan9693-serdes
> > + - microchip,lan9692-serdes
>
> If there is going to be a new version, keep rather increasing/growing
> alphanumerical order, but no need to resend just for this.

Ack.

>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> Best regards,
> Krzysztof
>

Thanks for reviewing!

/Daniel