Re: [PATCH v3] perf/x86/rapl: Fix the energy-pkg event for AMD CPUs

From: Dhananjay Ugwekar
Date: Tue Sep 10 2024 - 05:01:28 EST


On 9/9/2024 3:02 PM, Ingo Molnar wrote:
>
> * Dhananjay Ugwekar <Dhananjay.Ugwekar@xxxxxxx> wrote:
>
>>>>> Signed-off-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@xxxxxxx>
>>>>
>>>> Reviewed-by: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
>>>
>>> Note that I just merged the older v2 version into perf/urgent
>>
>> I'm not able to find the v2 version in perf/urgent right now, tip-bot had given the below link before
>> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=8d72eba1cf8cecd76a2b4c1dd7673c2dc775f514.
>> Have we changed our decision about keeping the v2 for backporting and "revert v2 + apply v4" post the PMU scope patchset?
>
> Yeah, so initially I thought that this comment of yours applied to -v2 as
> well:
>
> https://lore.kernel.org/all/b34e30bc-a003-4529-bcfe-8189ca7ddc5b@xxxxxxx
>
> ... but in hindsight, it's -v3 specific, right?

Yes, it is only applicable to v3 and I had posted v4 to fix this and now posted v5 to rebase v4 on top of a recent fix
in the PMU scope patchset(https://lore.kernel.org/all/8c09633c-5bf2-48a2-91a6-a0af9b9f2e8c@xxxxxxxxxxxxxxx/)

v5 Link: https://lore.kernel.org/linux-perf-users/20240910085504.204814-1-Dhananjay.Ugwekar@xxxxxxx/T/#u,

Please "revert v2 + apply v5" post the kan.liang's PMU scope patchset.

>
> So I've restored -v2 and it should go to Linus this week if all goes well.

Thanks!,

Dhananjay

>
> Thanks,
>
> Ingo