Re: [PATCH net-next v4 0/6] net: ethernet: ti: am65-cpsw: Add multi queue RX support

From: MD Danish Anwar
Date: Wed Sep 11 2024 - 04:20:16 EST




On 10/09/24 2:53 pm, Roger Quadros wrote:
> Hi,
>
> am65-cpsw can support up to 8 queues at Rx. So far we have
> been using only one queue (i.e. default flow) for all RX traffic.
>
> This series adds multi-queue support. The driver starts with
> 1 RX queue by default. User can increase the RX queues via ethtool,
> e.g. 'ethtool -L ethx rx <N>'
>
> The series also adds regmap and regfield support to some of the
> ALE registers. It adds Policer/Classifier registers and fields.
>
> Converting the existing ALE control APIs to regfields can be a separate
> exercise.
>
> Some helper functions are added to read/write to the Policer/Classifier
> registers and a default Classifier setup function is added that
> routes packets based on their PCP/DSCP priority to different RX queues.
>
> Signed-off-by: Roger Quadros <rogerq@xxxxxxxxxx>
> ---
> Changes in v4:
> - Use single macro AM65_CPSW_MAX_QUEUES for both TX and RX queues
> to simplify code
> - reuse am65_cpsw_get/set_per_queue_coalesce for am65_cpsw_get/set_coalesce.
> - return -EINVAL if unsupported tx/rx_coalesce_usecs in
> am65_cpsw_set_coalesce.
> - reverse Xmas tree declaration order fixes in cpsw_ale
> - Link to v3: https://lore.kernel.org/r/20240703-am65-cpsw-multi-rx-v3-0-f11cd860fd72@xxxxxxxxxx
>
> Changes in v3:
> - code style fixes
> - squashed patches 5 and 6
> - added comment about priority to thread mapping table.
> - Added Reviewed-by Simon Horman.
> - Link to v2: https://lore.kernel.org/r/20240628-am65-cpsw-multi-rx-v2-0-c399cb77db56@xxxxxxxxxx
>
> Changes in v2:
> - rebase to net/next
> - fixed RX stall issue during iperf
> - Link to v1: https://lore.kernel.org/r/20240606-am65-cpsw-multi-rx-v1-0-0704b0cb6fdc@xxxxxxxxxx
>
> ---
> Roger Quadros (6):
> net: ethernet: ti: am65-cpsw: Introduce multi queue Rx
> net: ethernet: ti: cpsw_ale: use regfields for ALE registers
> net: ethernet: ti: cpsw_ale: use regfields for number of Entries and Policers
> net: ethernet: ti: cpsw_ale: add Policer and Thread control register fields
> net: ethernet: ti: cpsw_ale: add policer/classifier helpers and setup defaults
> net: ethernet: ti: am65-cpsw: setup priority to flow mapping
>
> drivers/net/ethernet/ti/am65-cpsw-ethtool.c | 75 +++---
> drivers/net/ethernet/ti/am65-cpsw-nuss.c | 388 ++++++++++++++++------------
> drivers/net/ethernet/ti/am65-cpsw-nuss.h | 39 +--
> drivers/net/ethernet/ti/cpsw_ale.c | 287 ++++++++++++++++++--
> drivers/net/ethernet/ti/cpsw_ale.h | 62 ++++-
> 5 files changed, 594 insertions(+), 257 deletions(-)
> ---
> base-commit: bfba7bc8b7c2c100b76edb3a646fdce256392129
> change-id: 20240606-am65-cpsw-multi-rx-fb6cf8dea5eb
>
> Best regards,

For this series,
Reviewed-by: MD Danish Anwar <danishanwar@xxxxxx>

--
Thanks and Regards,
Danish