Re: [PATCH] dt-bindings: mailbox: mediatek,gce-mailbox: Stop requiring clock-names

[Conor Dooley]

On Thu, Sep 12, 2024 at 07:59:21AM +0000, AngeloGioacchino Del Regno wrote:
> Il 11/09/24 19:51, Conor Dooley ha scritto:
> > On Wed, Sep 11, 2024 at 12:43:27PM +0200, AngeloGioacchino Del Regno wrote:
> > > There is no reason to make specifying the clock-names property
> > > mandatory, as the Global Command Engine HW needs only one clock.
> > 
> > Have you checked to make sure that there are no users that do the lookup
> > by name?
> > 
> 
> It's just that I didn't want to mention any "driver" word in the commit description
> for a binding ;-)
> 
> (Of course I did, and the driver is not doing any by_name lookup)

It's fine to mention drivers in this case, it'd save us asking. Given
your choice of article, is the gce-mailbox not used outside of the
kernel?

> 
> > > 
> > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> > > ---
> > >   .../bindings/mailbox/mediatek,gce-mailbox.yaml        | 11 -----------
> > >   1 file changed, 11 deletions(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
> > > index cef9d7601398..ff5d010fbcf0 100644
> > > --- a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
> > > +++ b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
> > > @@ -56,17 +56,6 @@ required:
> > >     - interrupts
> > >     - clocks
> > > -allOf:
> > > -  - if:
> > > -      not:
> > > -        properties:
> > > -          compatible:
> > > -            contains:
> > > -              const: mediatek,mt8195-gce
> > > -    then:
> > > -      required:
> > > -        - clock-names
> > > -
> > >   additionalProperties: false
> > >   examples:
> > > -- 
> > > 2.46.0
> > > 
> 
>

Attachment: signature.asc
Description: PGP signature