Re: [PATCH v7 0/4] pressure: bmp280: Minor cleanup and interrupt support
From: Jonathan Cameron
Date: Sat Sep 14 2024 - 10:36:38 EST
On Sat, 14 Sep 2024 02:28:56 +0200
Vasileios Amoiridis <vassilisamir@xxxxxxxxx> wrote:
> Depends on this: https://lore.kernel.org/linux-iio/20240823172017.9028-1-vassilisamir@xxxxxxxxx
>
This looks fine, but given outstanding comments on that patch I can't
take it quite yet.
Jonathan
> Changes in v7:
>
> [PATCH 1/4]:
> - Use 5ms instead of 5000us in comment
> - Use USEC_PER_MSEC
> - Move parenthesis to make checkpatch.pl --strict happy
>
> [PATCH 2/4]:
> - Remove interrupt description since enforcement was added.
>
> Added also review tags for patches 1,3 and ack tag for patch 2.
>
> ---
> v6: https://lore.kernel.org/linux-iio/20240912233234.45519-1-vassilisamir@xxxxxxxxx
> v5: https://lore.kernel.org/linux-iio/20240902184222.24874-1-vassilisamir@xxxxxxxxx
> v4: https://lore.kernel.org/linux-iio/20240828205128.92145-1-vassilisamir@xxxxxxxxx
> v3: https://lore.kernel.org/linux-iio/20240823181714.64545-1-vassilisamir@xxxxxxxxx
> v2: https://lore.kernel.org/linux-iio/20240725231039.614536-1-vassilisamir@xxxxxxxxx
> v1: https://lore.kernel.org/linux-iio/20240711211558.106327-1-vassilisamir@xxxxxxxxx
>
> Vasileios Amoiridis (4):
> iio: pressure: bmp280: Use sleep and forced mode for oneshot captures
> dt-bindings: iio: pressure: bmp085: Add interrupts for BMP3xx and
> BMP5xx devices
> iio: pressure: bmp280: Add data ready trigger support
> iio: pressure: bmp280: Move bmp085 interrupt to new configuration
>
> .../bindings/iio/pressure/bmp085.yaml | 22 +-
> drivers/iio/pressure/bmp280-core.c | 580 ++++++++++++++++--
> drivers/iio/pressure/bmp280-i2c.c | 4 +-
> drivers/iio/pressure/bmp280-spi.c | 4 +-
> drivers/iio/pressure/bmp280.h | 43 ++
> 5 files changed, 612 insertions(+), 41 deletions(-)
>
>
> base-commit: fec496684388685647652ab4213454fbabdab099
> prerequisite-patch-id: e4f81f31f4fbb2aa872c0c74ed4511893eee0c9a