Re: [PATCH net-next V2 4/5] net: lan743x: Implement phylink pcs

[Andrew Lunn]

> As I have mentioned before I am not (and will likely never be) a
> Linux expert. I have just been advising Raju from the perspective of
> how the chip hardware works, the drivers I have written for it for a
> different OS, and what our customers have been requiring from us. I
> wasn't advocating against instantiating a second MDIO bus or
> whatever else makes sense in the Linux frameworks/environment,
> specially if the overhead to implement it is low and allows for
> richer or alternative use cases. I was just pointing out potential
> problems based on my knowledge of our hardware and the information I
> was told (now obviously misunderstood and/or incomplete) about these
> newer Linux frameworks (phylink, xpcs, sfp) by Raju / was
> understanding from your email.

Not a problem. That is partially why we do reviews, to make sure the
architecture is correct. And there is a tendency for developers and
drivers coming from other OSes to re-invent wheels, because some other
OSes do not provide those wheels. With Linux you have a bigger API to
understand, but less code to write.

	Andrew