Re: [PATCH v2] scsi: ufs: Zero utp_upiu_req at the beginning of each command

From: Bart Van Assche
Date: Tue Sep 17 2024 - 10:31:40 EST


On 9/16/24 11:52 PM, Avri Altman wrote:
Is the below proposal evidently better? e.g. with respect of
efficiency, simplicity, readability etc.?

The approach I proposed has two advantages:
* All code that initializes *lrbp->ucd_req_ptr occurs in the same
function. I think that is a significant advantage with regard to
maintainability.
* ucd_req_ptr->header is initialized once instead of twice. Hence
the approach I proposed is more efficient.

Thanks,

Bart.