Re: [PATCH v2 0/2] tools: power: cpupower: Allow overriding cross-compiling envs
From: John B. Wyatt IV
Date: Thu Sep 19 2024 - 12:38:50 EST
Hi Peng,
A few comments:
> V2:
> subject update, commit log update in patch 1, 2
> Use strerror in patch 1
> without patch 2, need update Makefile with 'CROSS =
> [cross toolchain path]/aarch64-poky-linux-'
Version information is applied per commit patch. Not in the cover letter.
Example:
https://lore.kernel.org/linux-pm/20240905021916.15938-2-jwyatt@xxxxxxxxxx/
Reference:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format
You will need to submit a V3 version of this.
> without patch 2, need update Makefile with 'CROSS =
> [cross toolchain path]/aarch64-poky-linux-'
I am not sure what this is saying exactly. Please clarify.
> Subject: Re: [PATCH v2 0/2] tools: power: cpupower: Allow overriding
Not sure you need 'tools: power: cpupower:' in the cover letter.
> pm: cpupower: bench: print config file path when open cpufreq-bench.conf fails
I do not think you need bench either.
--
Sincerely,
John Wyatt
Software Engineer, Core Kernel
Red Hat