RE: [PATCH v2 0/2] tools: power: cpupower: Allow overriding cross-compiling envs

[Peng Fan]

Hi John,

> Subject: Re: [PATCH v2 0/2] tools: power: cpupower: Allow overriding
> cross-compiling envs
> 
> Hi Peng,
> 
> A few comments:
> 
> > V2:
> >  subject update, commit log update in patch 1, 2  Use strerror in
> > patch 1  without patch 2, need update Makefile with 'CROSS =  [cross
> > toolchain path]/aarch64-poky-linux-'
> 
> Version information is applied per commit patch. Not in the cover
> letter.
> 
> Example:
> 
> https://lore.kernel.org/linux-pm/20240905021916.15938-2-jwyatt@xxxxxxxxxx/
> Reference:
> 
> 
> You will need to submit a V3 version of this.
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format

Sure, I will follow in v3.

> >  without patch 2, need update Makefile with 'CROSS =  [cross
> toolchain
> > path]/aarch64-poky-linux-'
> 
> I am not sure what this is saying exactly. Please clarify.
> 

Shuah asked to put that in changelog,

https://lore.kernel.org/all/0f8df90f-007a-483e-83ce-df8ff0e99791@xxxxxxxxxxxxxxxxxxx/

I could put in patch 1/2 change log in V3.

> > Subject: Re: [PATCH v2 0/2] tools: power: cpupower: Allow
> overriding
> 
> Not sure you need 'tools: power: cpupower:' in the cover letter.

Will use "tools: power:" in v3.
> 
> > pm: cpupower: bench: print config file path when open
> > cpufreq-bench.conf fails
> 
> I do not think you need bench either.

Will drop "bench" in v3.


Thanks,
Peng.

> 
> --
> Sincerely,
> John Wyatt
> Software Engineer, Core Kernel
> Red Hat